Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDTOEND_ENABLE env value is not working #179

Open
rjshrjndrn opened this issue Dec 14, 2022 · 4 comments · May be fixed by #245
Open

ENDTOEND_ENABLE env value is not working #179

rjshrjndrn opened this issue Dec 14, 2022 · 4 comments · May be fixed by #245

Comments

@rjshrjndrn
Copy link

Hi,

First of all, thank you for this amazing exporter.

docker run -p 9080:8080 -e ENDTOEND_ENABLED=true -e KAFKA_TLS_ENABLED=true -e KAFKA_BROKERS=b-1.xxxxx.amazonaws.com:9094 vectorized/kminion:v2.2.1

But the end to end monitoring is not working because the yaml config says endToend and in the config parser, all config is converted to small case.

Would it help to change the endToEnd to endtoend ?

@weeco
Copy link
Contributor

weeco commented Dec 14, 2022

Hey @rjshrjndrn ,
we had the same issue in https://github.com/redpanda-data/console . We fixed this as shown here: https://github.com/redpanda-data/console/blob/a0408520cedfdd73f4f444ddbfd364faceeb0b5f/backend/pkg/config/config.go#L162-L177

Are you interested in contributing something similar in KMinion?

@rjshrjndrn
Copy link
Author

Sure. I'll give it a go. Thanks for the reference.

@doxsch
Copy link

doxsch commented Feb 13, 2024

We had a similar problem. However, we wanted to overwrite values from the config file using environment variables. I submitted a fix for this in #231.
However, I was correctly pointed out by @weeco that this does not fix the problem here. The workaround he linked and suggested fixes it in any case and not only when a config file is specified using CONFIG_FILEPATH. That's why I submitted his workaround in #245.

@doxsch
Copy link

doxsch commented Apr 16, 2024

Hi @weeco

Let me know if there’s anything more I can help with to get this change merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants