Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated paths in benthos migration #1591

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

dersvenhesse
Copy link
Contributor

In the migration guide the docker path doesn't necessarily need the domain and the helm command was missing the name.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@david-yu david-yu requested a review from ooesili November 4, 2024 18:46
@ooesili
Copy link
Contributor

ooesili commented Nov 4, 2024

Nice catch, thanks for the PR!

@ooesili ooesili enabled auto-merge (squash) November 4, 2024 18:48
@ooesili ooesili merged commit e326f1f into redpanda-data:main Nov 4, 2024
11 checks passed
@dersvenhesse dersvenhesse deleted the patch-1 branch November 4, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants