gcp_cloud_storage never gets ready

[AndreasBergmeier6176]

I have a config, where I connect gcp_cloud_storage to gcp_pubsub.
The respective Kubernetes Deployment never becomes ready.

Looking into the implementation of /ready, it checks for v.IsReady() && v.IsRunning() in line.

Which seems odd to me since the endpoint is named ready. Anyway - while I naively assume that IsReady should be true here, I wonder whether IsRunning does actually happen for gcp_cloud_storage ever/often?

Increasing the log level I see at the end:

Waiting for pending acks to resolve before shutting down
Pending acks resolved.

It might be the problem of returning End of Input.

[mihaitodor]

Hey @AndreasBergmeier6176 👋 It looks like the code here doesn't use any timeout for the context that's passed to pubsub.NewClient() and we should probably set one and expose it as a config parameter. I'll take this task as a TODO.

[AndreasBergmeier6176]

The problem was actually that gcp_cloud_storage was closing the input once the iteration was done. Which in hindsight may be okish - but it may be good to mention in the docs to maybe rather use storage notifications for streaming.