From 4d46ac41cb05705ad29e2a23da2df2ff3c9c574d Mon Sep 17 00:00:00 2001 From: Ivo Jimenez Date: Fri, 8 Nov 2024 18:13:38 -0700 Subject: [PATCH] gha: remove hard-coded dockerhub username Change the secret being fetched by a new one that is named following our secret naming guidelines. In addition, remove hard-coded username to allow easy change in the future of this value --- .github/workflows/docker_edge.yml | 4 ++-- .github/workflows/release.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker_edge.yml b/.github/workflows/docker_edge.yml index c84d4c1631..c568333ac7 100644 --- a/.github/workflows/docker_edge.yml +++ b/.github/workflows/docker_edge.yml @@ -38,13 +38,13 @@ jobs: uses: aws-actions/aws-secretsmanager-get-secrets@v2 with: secret-ids: | - ,sdlc/prod/github/dockerhub_token + ,sdlc/prod/github/dockerhub parse-json-secrets: true - name: Login to Docker Hub uses: docker/login-action@v3 with: - username: vectorizedbot + username: ${{ env.DOCKERHUB_USER }} password: ${{ env.DOCKERHUB_TOKEN }} - name: Install Buildx diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cee38635cf..44baff7c56 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -124,13 +124,13 @@ jobs: uses: aws-actions/aws-secretsmanager-get-secrets@v2 with: secret-ids: | - ,sdlc/prod/github/dockerhub_token + ,sdlc/prod/github/dockerhub parse-json-secrets: true - name: Login to Docker Hub uses: docker/login-action@v3 with: - username: vectorizedbot + username: ${{ env.DOCKERHUB_USER }} password: ${{ env.DOCKERHUB_TOKEN }} - name: Install Buildx