-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #75
base: main
Are you sure you want to change the base?
Add unit tests #75
Conversation
can you update the CI workflow so react tests are run? |
@fbricon can you explain what you meant by updating the CI workflow? |
update https://github.com/redhat-developer/vscode-granite/blob/main/.github/workflows/build.yaml so that tests are run by the CI agent |
@neehar18 no. You can try running "npm test" at the root of the project and see if your react tests are run |
also please fix the conflicts |
@fbricon got it. I'll make the necessary changes and update the PR. Also, when do you want the tests to be run? Before building extension and generating vsix pkg or after? |
after packaging, so we can still test the vsix even if there's a failure |
Signed-off-by: Neehar Kurukunda <[email protected]>
@@ -0,0 +1,72 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test results don't belong in this repo.
please add it to .gitignore so it's excluded
@@ -3,6 +3,7 @@ import "./App.css"; | |||
import { useCallback, useEffect, useState } from "react"; | |||
import ModelList, { ModelOption } from "./ModelList"; | |||
import { ProgressData } from "../../src/commons/progressData"; | |||
import React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems unnecessary
@@ -1,3 +1,4 @@ | |||
import React from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems unnecessary
Fixes #49