Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Request] Move hardcoded locators from TextEditor.ts to locators #1504

Open
pospisilf opened this issue Aug 30, 2024 · 0 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@pospisilf
Copy link
Contributor

Describe the request

Some of the locators for newer version are currently hardcoded, this should be replaced with corresponding locators in locators lib.

Example:
const breakpointContainer = TextEditor.versionInfo.version >= '1.80.0' ? await this.findElement(By.className('glyph-margin-widgets')) : lineOverlay;

const name = TextEditor.versionInfo.version < '1.59.0' ? 'Next match' : 'Next Match';

Usage

Cleaner code.

@pospisilf pospisilf added enhancement New feature or request new-issue New issue which was not discussed yet labels Aug 30, 2024
@djelinek djelinek removed the new-issue New issue which was not discussed yet label Aug 30, 2024
@djelinek djelinek added this to the BACKLOG milestone Aug 30, 2024
@pospisilf pospisilf assigned pospisilf and unassigned pospisilf Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants