Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚫 Bug] install-vsix fails on windows when file pattern like ./**.vsix is provided #1354

Open
jiri-skrivanek opened this issue Jun 11, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jiri-skrivanek
Copy link

Describe the bug

install-vsix fails on windows when file pattern like ./**.vsix is provided. It works on unix. Related code in node_modules/vscode-extension-tester/out/extester.js is

   const uri = new url_1.URL(vsixFile);
            if (!(process.platform === 'win32' && /^\w:/.test(uri.protocol))) {
                target = path.basename(vsixFile);
            }

Steps to reproduce

node node_modules/vscode-extension-tester/out/cli.js install-vsix --vsix_file ./**.vsix

Logs

Error: File ./**.vsix does not exist
    at ExTester.installVsix (D:\repo\myextension\node_modules\vscode-extension-tester\out\extester.js:87:27)
    at D:\repo\myextension\node_modules\vscode-extension-tester\out\cli.js:41:18

Operating System

Windows11

Visual Studio Code

1.90.0

vscode-extension-tester

7.3.2

NodeJS

20.12.2

npm

No response

@jiri-skrivanek jiri-skrivanek added bug Something isn't working new-issue New issue which was not discussed yet labels Jun 11, 2024
@jiri-skrivanek
Copy link
Author

Any ideas abut this?

@djelinek djelinek removed the new-issue New issue which was not discussed yet label Jul 18, 2024
@djelinek djelinek added this to the BACKLOG milestone Jul 18, 2024
@djelinek djelinek self-assigned this Jul 24, 2024
@djelinek djelinek modified the milestones: BACKLOG, NEXT Jul 24, 2024
@djelinek
Copy link
Collaborator

Any ideas abut this?

Hello, I am starting to investigate this issue. I will let you know with my findings ASAP 🙂

Thank you for your patience.

@jiri-skrivanek
Copy link
Author

Any new observations?

@djelinek
Copy link
Collaborator

Any new observations?

hello, I was on a PTO last week, so I will continue on that ASAP.

At the moment I was able to reproduce on Windows VM, so I will take a look more closely into current implementation and options how to improve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants