Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add nodeSelector and affinity #19

Open
emmanuelstroem opened this issue Mar 9, 2022 · 1 comment
Open

[FEATURE] Add nodeSelector and affinity #19

emmanuelstroem opened this issue Mar 9, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@emmanuelstroem
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In a scenario where there is a dedicated node/nodepool on which to schedule the runner,
the helm-chart does not have the required values to achieve that.

Describe the solution you'd like

Add nodeSelector and affinity specs to the deployment.yaml template.
These should enable specifying nodes if need be.

Describe alternatives you've considered

I have considered through Helm CLI using --set nodeSelector.<key>=<value> but this requires the template to be prepared first. 🙈

Additional context
@emmanuelstroem emmanuelstroem added the enhancement New feature or request label Mar 9, 2022
@emmanuelstroem emmanuelstroem mentioned this issue Mar 9, 2022
Merged
8 tasks
@emmanuelstroem
Copy link
Contributor Author

@petracvv
I know you all must be occupied in these times 🙏

I did open this issue and an immediate PR #20 just in case.

Do let me know if its feasible or if there is a different and or better approach to take in this regard 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emmanuelstroem