Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type of AlternativePaymentMethods start and initiate #885

Open
jochem-van-eldijk opened this issue Jul 11, 2024 · 0 comments
Open

Comments

@jochem-van-eldijk
Copy link

jochem-van-eldijk commented Jul 11, 2024

Passing the options object to the start method does noting:

start: (data: AlternativePaymentMethodOptions) => Promise<void>;

instead it should be passed when creating a AlternativePaymentMethodsInstance here:

export type AlternativePaymentMethods = () => AlternativePaymentMethodsInstance;

you can see this also being done in your example repo: recurly-integration-examples/public/alternative-payment-methods/ideal.html

on this line: https://github.com/recurly/recurly-integration-examples/blob/a1b6502b736f225b04c33e3249822830bad0e71a/public/alternative-payment-methods/ideal.html#L64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant