You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that the method _update_workflow_status in consumer.py is now being called in rest/utils.py. I think a refactor is needed, in particular:
The logic on how to update the status/logs/job progress/job cache of workflows should not be in consumer.py, but in a dedicated module/package
There should only be one way (thus, one function) to stop a workflow (and to start/delete/... it), which both updates the database and interacts with k8s as needed. These functions would/should use the ones from (1), and should not be part of rest.
Proper design/planning is needed, though. Should we do it later or as part of this PR?
Note that the method
_update_workflow_status
inconsumer.py
is now being called inrest/utils.py
. I think a refactor is needed, in particular:consumer.py
, but in a dedicated module/packagerest
.Proper design/planning is needed, though. Should we do it later or as part of this PR?
Originally posted by @mdonadoni in #563 (comment)
The text was updated successfully, but these errors were encountered: