Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reafactor: centralise functions to update status of workflows #565

Open
mdonadoni opened this issue Feb 1, 2024 · 0 comments
Open

reafactor: centralise functions to update status of workflows #565

mdonadoni opened this issue Feb 1, 2024 · 0 comments

Comments

@mdonadoni
Copy link
Member

Note that the method _update_workflow_status in consumer.py is now being called in rest/utils.py. I think a refactor is needed, in particular:

  1. The logic on how to update the status/logs/job progress/job cache of workflows should not be in consumer.py, but in a dedicated module/package
  2. There should only be one way (thus, one function) to stop a workflow (and to start/delete/... it), which both updates the database and interacts with k8s as needed. These functions would/should use the ones from (1), and should not be part of rest.

Proper design/planning is needed, though. Should we do it later or as part of this PR?

Originally posted by @mdonadoni in #563 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant