Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest: improve error message and status code for symlinks #480

Open
audrium opened this issue Nov 15, 2022 · 0 comments
Open

rest: improve error message and status code for symlinks #480

audrium opened this issue Nov 15, 2022 · 0 comments

Comments

@audrium
Copy link
Member

audrium commented Nov 15, 2022

After introducing rest: avoid following symlinks inside workspaces we now raise a general exception in case someone tries to do any file operation to a symlink:

rc download -w test symlinkfile
==> ERROR: File symlinkfile could not be downloaded: Error 500 Internal Server Error Symlinks not allowed

as an MVP we could improve the error message and status code to handle this case gratefully.

Alternatively, we could let user know that the manipulated file is a symlink. The server would have had to send this "file type" information along with the reply.

For example even for successful messages:

$ reana-client rm -w rucio etc
==> SUCCESS: File etc was successfully deleted.
==> SUCCESS: 4 bytes freed up.

Here etc is a symlink, but client does not know that. We could improve the response from the client to inform the user accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant