Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify e2e and local tests #7

Open
swenzel opened this issue Aug 31, 2018 · 0 comments
Open

Unify e2e and local tests #7

swenzel opened this issue Aug 31, 2018 · 0 comments
Labels
refactoring Changes code but not functionality

Comments

@swenzel
Copy link
Contributor

swenzel commented Aug 31, 2018

All tests should be able to run both with a real kafka backend and with a mock. We wouldn't want to maintain two different sets of tests.
@swenzel swenzel added the refactoring Changes code but not functionality label Aug 31, 2018
hfjn pushed a commit that referenced this issue May 23, 2019
Merged in change-flush-logic (pull request #7)
f62699a 
Change flush logic

Approved-by: Felix Eggert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Changes code but not functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swenzel