Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node/php/dotnet: figure out what to do about baseLogUrl #562

Open
domharrington opened this issue Aug 29, 2022 · 1 comment
Open

node/php/dotnet: figure out what to do about baseLogUrl #562

domharrington opened this issue Aug 29, 2022 · 1 comment
Labels
dotnet Issues related to our .NET SDK node Issues related to our Node SDK php Issues related to our PHP SDK refactor Issues about tackling technical debt

Comments

@domharrington
Copy link
Member

Do we still want to accept it? Is this something that we should be doing for them, or encouraging it via the code samples instead?

@domharrington domharrington changed the title node: figure out what to do about baseLogUrl node/php/dotnet: figure out what to do about baseLogUrl Aug 30, 2022
@gratcliff
Copy link
Member

gratcliff commented Jul 26, 2024

I'm in favor of dropping configuration support for this. We should implicitly be getting this value via the call to ReadMe's dash API.

This will require us to consume that endpoint's response more holistically and apply it to request contexts, though.

@gratcliff gratcliff added the refactor Issues about tackling technical debt label Jul 26, 2024
@erunion erunion added dotnet Issues related to our .NET SDK php Issues related to our PHP SDK node Issues related to our Node SDK labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Issues related to our .NET SDK node Issues related to our Node SDK php Issues related to our PHP SDK refactor Issues about tackling technical debt
Projects
None yet
Development

No branches or pull requests

3 participants