Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button without text or aria label violates Axe rule #45

Open
MarkPare opened this issue Dec 11, 2019 · 1 comment
Open

Button without text or aria label violates Axe rule #45

MarkPare opened this issue Dec 11, 2019 · 1 comment

Comments

@MarkPare
Copy link

Critical rule violated by component:

https://dequeuniversity.com/rules/axe/3.4/button-name?application=axeAPI

I believe this introduced by this #26 in response to #22

@saitonakamura
Copy link
Contributor

Hi @MarkPare , I'm the author of the PR. I took a quick glance over this rule, and I'm not sure it's valid in case of role="switch". It essentially the same as a simple checkbox: a combination of role="checkbox" (switch) and checked attribute (aria-checked), plus a label explaining what it is somewhere outside. I'm not an a11y expert, but it seems to that this rule should take role="switch" and role="checkbox" into consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants