This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Set default value of target for zone #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If no target is specified, the attribute should not be set at all. If it is set to '%%REJECT%%' by default, it is not doing the right thing! From the man page: Not specifying the target attribute in the xml file is the default. If the target attribute is set, it must be one of "ACCEPT|%%REJECT%%|DROP". But that means ALL packages matching the zone, will be ACCEPTed, REJECTed, DROPed. No way to specify individual ports or services. That can only be done if target is "{chain}ZONE{zone}". |
|
This still leaves the need for a a fix for #15 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comments, target should have a default value of reject.
Fixes #15