Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Start/stop program in monit config files broken by commit 3fcbfa5 #972

Open
git-harry opened this issue Oct 27, 2014 · 0 comments
Open

Start/stop program in monit config files broken by commit 3fcbfa5 #972

git-harry opened this issue Oct 27, 2014 · 0 comments
Labels

Comments

@git-harry
Copy link
Contributor

Before the commit:

# cat monit/conf.d/keystone.conf
# This file autogenerated by Chef
# Do not edit, changes will be overwritten
check process keystone matching "^((/usr/bin/)?python\d? )?(/usr/bin/)?keystone-all\b"
  start program = "/usr/sbin/service keystone start"
  stop program = "/usr/sbin/service keystone stop"
  if failed host 10.240.0.1 port 35357 protocol HTTP then restart
  if failed host 10.240.0.1 port 5000 protocol HTTP then restart

After the commit:

# cat monit2/conf.d/keystone.conf
# This file autogenerated by Chef
# Do not edit, changes will be overwritten
check process keystone matching "^((/usr/bin/)?python\d? )?(/usr/bin/)?keystone-all\b"
  start program = "keystone"
  stop program = "keystone"
  if failed host 10.240.0.1 port 35357 protocol HTTP then restart
  if failed host 10.240.0.1 port 5000 protocol HTTP then restart

#860 tracks the history of the original bug.

@git-harry git-harry added the bug label Oct 27, 2014
git-harry added a commit to git-harry/monit that referenced this issue Oct 27, 2014
3fcbfa5 introduced bug whereby service_bin, script_name, start_cmd and
stop_cmd must be explicitly specified by the resource.

This commit requires a resource to specify a script_name otherwise
start_program and stop_program supplied to the template are "".

Issue rcbops/chef-cookbooks#972
Issue rcbops/chef-cookbooks#860
git-harry added a commit to git-harry/monit that referenced this issue Oct 29, 2014
3fcbfa5 introduced bug whereby service_bin, script_name, start_cmd and
stop_cmd must be explicitly specified by the resource.

This commit requires a resource to specify a script_name otherwise
start_program and stop_program supplied to the template are "".

Issue rcbops/chef-cookbooks#972
Issue rcbops/chef-cookbooks#860
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant