Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move MatchingLabels to association.go [1/N] #2732

Closed
rueian opened this issue Jan 11, 2025 · 1 comment · Fixed by #2756
Closed

[Refactor] Move MatchingLabels to association.go [1/N] #2732

rueian opened this issue Jan 11, 2025 · 1 comment · Fixed by #2756
Assignees

Comments

@rueian
Copy link
Contributor

rueian commented Jan 11, 2025

Following #2045

We like to move all client.MatchingLabels{utils.RayClusterLabelKey: string} to the association.go, so that we can maintain consistency in the association methods by not scattering MatchingLabels everywhere.

Including:

filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name}

filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name}

filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: newInstance.Name}

@fscnick
Copy link
Contributor

fscnick commented Jan 12, 2025

Hi @rueian, I'd like to help with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants