Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] add a doc for sharing a Grafana instance across multiple KubeRay custom resources #49742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Doc] add a doc for sharing a Grafana instance across multiple KubeRay custom resources #49742

wants to merge 1 commit into from
+10 −4

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Jan 9, 2025 •
edited
Loading

Why are these changes needed?

Update the Ray doc to see the metrics for a single RayCluster CR in a shared Grafana instance, also fixed some incorrect URL.

The Case1 import method needs to wait until ray-project/kuberay#2685 is merged.

Related issue number

Closes ray-project/kuberay#2668

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@win5923 win5923 force-pushed the grafana/filterRayClusters branch 3 times, most recently from 556731e to 57e74f6 Compare January 9, 2025 16:09
@kevin85421 kevin85421 self-assigned this Jan 10, 2025
@win5923 win5923 force-pushed the grafana/filterRayClusters branch from 57e74f6 to 0769db1 Compare January 11, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@kevin85421 kevin85421 Awaiting requested review from kevin85421 kevin85421 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add a doc for sharing a Grafana instance across multiple KubeRay custom resources
2 participants
@win5923 @kevin85421