Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent spelling in symbol definition: interp_add_accumulater #1992

Open
smitelli opened this issue Oct 21, 2024 · 2 comments
Open

Inconsistent spelling in symbol definition: interp_add_accumulater #1992

smitelli opened this issue Oct 21, 2024 · 2 comments

Comments

@smitelli
Copy link

In hardware/interp.h, the definition of the inline function interp_add_accumulater doesn't match the dictionary spelling of "accumulator" used anywhere else in the project or its documentation.

Since changing it could break existing user code, is this the type of thing where there is precedent to keep the incorrect spelling as an alias?

@peterharperuk
Copy link
Contributor

Usually we add a correct version of the function but keep the old version around to maintain compatibility

@lurch
Copy link
Contributor

lurch commented Oct 22, 2024

Yeah the usual approach is to rename the actual function itself, and then add a #define for the old name, so that existing code keeps working; similar to this .

So in your case you'd probably want to add something like:

#define interp_add_accumulater(interp, lane, val) interp_add_accumulator(interp, lane, val)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants