Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Add support to Tizen #54

Closed
wants to merge 16 commits into from
Closed

Add support to Tizen #54

wants to merge 16 commits into from

Conversation

dead
Copy link
Contributor

@dead dead commented Nov 18, 2017

How to use:

  • Install Tizen Studio (latest version)
  • Install the Native CLI, Web CLI, TV and Certficate Manager packages. (Using the "Package Manager")
  • Set TIZEN_CLI environment variable to the Tizen CLI folder. (Usually <TIZEN_STUDIO>/tools/ide/bin)
  • Setup a certificate using the "Certficate Manager"
  • Execute react-tv run-tizen inside a react-tv application 😄

Benchmark

emulator-x86_64_2017-11-17_23-25-26

@dead dead changed the title Tizen cli Add support to Tizen Nov 18, 2017
@raphamorim
Copy link
Owner

raphamorim commented Nov 18, 2017

Amazing @dead!
Can you update the README.md and add info about Tizen?

  • update supported tv list
  • add reference to react-tv run-tizen

I'll test this PR on this weekend. 👍 ❤️

@raphamorim raphamorim added this to the 0.4.0 milestone Nov 21, 2017
@raphamorim
Copy link
Owner

raphamorim commented Nov 22, 2017

Sorry for no make any review for this PR yet :(

I'll close #63 #58 for finish 0.3.0 and then I'll work on it.

@JosePedroDiasSky
Copy link

🙌

@raphamorim raphamorim mentioned this pull request Dec 17, 2017
8 tasks
@raphamorim
Copy link
Owner

@dead I'll work on it this week, can you rebase it?

@dead
Copy link
Contributor Author

dead commented Dec 19, 2017

@raphamorim done 😄

@raphamorim raphamorim mentioned this pull request Dec 29, 2017
@raphamorim
Copy link
Owner

@dead I solved other conflicts and create another PR with your commits.
I'll go on with #104 (some things to do yet: adjust for macos env).

When it ends/merged I'll notify you and ask if it's still working on Windows Env.

@Blinnikov
Copy link

Hi, @dead.
Could you please share benchmark code you've used?

@raphamorim can we include it in the repo to allow any user run performance tests?

@dead
Copy link
Contributor Author

dead commented Jan 15, 2018

@Blinnikov
@raphamorim removed the benchmark code. I think it wasn't a real benchmark...

@raphamorim
Copy link
Owner

Yeah, isn't a real benchmark.
Maybe a good benchmark is check memory usage (footprint or other way) based on renders updates.

@raphamorim raphamorim closed this Jan 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants