Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highcharts Editor modal is only available in English #278

Closed
dan-bowerman opened this issue Apr 3, 2024 · 2 comments
Closed

Highcharts Editor modal is only available in English #278

dan-bowerman opened this issue Apr 3, 2024 · 2 comments
Labels
Bug Something isn't working Charts Issues concerning Highcharts graphing functionality Consult UI/UX Issues that require consultation with the UI/UX team to move forward Discussion Priority: Urgent This task should be grabbed before any others

Comments

@dan-bowerman
Copy link
Member

The Highcharts Editor modal is not localized and is displaying in English in the Editor, even in French context.

This will require a custom build of the Highcharts Editor. This will also likely require a bunch of translations.

https://github.com/highcharts/highcharts-editor/wiki/Localization

@dan-bowerman dan-bowerman added Bug Something isn't working Priority: Urgent This task should be grabbed before any others Discussion Charts Issues concerning Highcharts graphing functionality labels Apr 3, 2024
@RyanCoulsonCA RyanCoulsonCA self-assigned this Apr 25, 2024
@RyanCoulsonCA
Copy link
Member

Gave this one a shot but I'm running into a bunch of issues. I'm going to move this back to To Do, and I'll put some info below in case someone else wants to give this a shot.

  1. I dug through the Highcharts code and replaced a bunch of hardcoded English text with highed.getLocalizedStr('<translation.string>') (my code changes are in this repo). However, there's some English text in the editor that I can't find in the codebase. Not sure where it's coming from, maybe being pulled from elsewhere?
  2. The bigger issue is that I can't get the editor to build, both with my changes and without. Below are a few of the errors I'm running into:

    Error 1: gulp[17572]: c:\ws\src\node_contextify.cc:696: Assertion 'args[1]->IsString()' failed. [GitHub, StackOverflow]
  • I managed to get this working by running npm install natives and npm audit fix as recommended in the Stackoverflow thread above.

    Error 2: ReferenceError: primordials is not defined [StackOverflow]

  • Using the override recommendation in the thread fixed this.

    Error 3: Missing file highed.editor.config.json. I created the file and added {} to it to get past this issue. Not sure if this file is supposed to be included in the repo or whether what I did is what we're supposed to do.

After fixing these 3 errors the build ran successfully, however when I moved the files in to Storylines the chart editor was totally broken and wouldn't work. I've attempted building with 3 different node versions, v6.17.1, v11.0.0, and v18.3.0.

@RyanCoulsonCA RyanCoulsonCA removed their assignment May 1, 2024
@dan-bowerman dan-bowerman added the Consult UI/UX Issues that require consultation with the UI/UX team to move forward label Jun 6, 2024
@dan-bowerman
Copy link
Member Author

Related ramp4-pcar4/highcharts-editor#8

@szczz szczz closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Charts Issues concerning Highcharts graphing functionality Consult UI/UX Issues that require consultation with the UI/UX team to move forward Discussion Priority: Urgent This task should be grabbed before any others
Projects
None yet
Development

No branches or pull requests

3 participants