Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intelligently set z_error field for mock catalogs #151

Open
sjforeman opened this issue Jul 30, 2021 · 2 comments
Open

Intelligently set z_error field for mock catalogs #151

sjforeman opened this issue Jul 30, 2021 · 2 comments

Comments

@sjforeman
Copy link
Contributor

The SpectroscopicCatalog container has a z_error field that currently isn't modified by the Add{Gaussian,EBOSS}ZErrorsToCatalog tasks. It would make sense to store the standard deviation of the distribution the z errors are drawn from (added in quadrature to the existing z_error value if one exists).
@sjforeman sjforeman mentioned this issue Jul 31, 2021
Merged
@ljgray
Copy link
Contributor

ljgray commented Sep 29, 2022

@sjforeman Is this issue resolved in #149? If so, we should close it

@sjforeman
Copy link
Contributor Author

@ljgray Unfortunately no - in #149, we punted on deciding what exactly the z_error field should store (see #149 (comment)), so we didn't write any code to set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjforeman @ljgray