Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any reason not to merge _Storage and _StorageRoot? #116

Open
nritsche opened this issue Mar 3, 2020 · 2 comments
Open

Is there any reason not to merge _Storage and _StorageRoot? #116

nritsche opened this issue Mar 3, 2020 · 2 comments
Assignees
Labels

Comments

@nritsche
Copy link
Contributor

nritsche commented Mar 3, 2020

@kiyo-masui after you had good arguments against the last proposal of changing the design, I'm hoping to get your opinion once again (again).

According to @jrs65 there's no good reason anymore to keep _Storage and _StorageRoot two separate classes.

@nritsche nritsche self-assigned this Mar 3, 2020
@nritsche nritsche changed the title Is there any reason not to merge _Storage and _Storage_root? Is there any reason not to merge _Storage and _StorageRoot? Mar 3, 2020
@kiyo-masui
Copy link
Contributor

I would merge this issue into #115. No point in tackling them separately and once you figure out how these classes work you'll know the answer to the question.

@jrs65
Copy link
Contributor

jrs65 commented Mar 3, 2020

Yeah. I agree with Kiyo here. I think the whole module needs some refactoring to reduce the structural complexity. These items were two of the things I thought possible, but they should really be considered in combination.

@radiocosmology radiocosmology deleted a comment from jrs65 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants