Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve type safety with rlang or assertthat or checkmate #23

Open
e-kotov opened this issue Aug 12, 2024 · 3 comments
Open

improve type safety with rlang or assertthat or checkmate #23

e-kotov opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@e-kotov
Copy link
Member

e-kotov commented Aug 12, 2024

Improve type safety of the package

@Robinlovelace
Copy link
Collaborator

{checkmate} is another option, mild preference for {rlang} as it's already an import. Simple is good.

@e-kotov e-kotov changed the title improve type safety with rlang or assertthat improve type safety with rlang or assertthat or checkmate Aug 14, 2024
@e-kotov e-kotov added this to the first stable release milestone Oct 3, 2024
@e-kotov e-kotov added the enhancement New feature or request label Oct 3, 2024
@e-kotov
Copy link
Member Author

e-kotov commented Oct 20, 2024

The {rlang} option is problematic, it is more of a hack right now and will (may) be superseded by a separate package: tidyverse/design#160 .

Therefore, I will either use {checkmate}, as it is still actively maintained, or will simply do with our internal check functions, as we have a lot of argument normalisation functions anyway.

@Robinlovelace
Copy link
Collaborator

Sounds good, simple good, and it is possible to over-engineer (and over-think) such things, stopifnot() also an option..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants