Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update r-stretch Documentation #845

Closed
wants to merge 1 commit into from
Closed

Update r-stretch Documentation #845

wants to merge 1 commit into from

Conversation

RoyiAvital
Copy link
Contributor

@RoyiAvital RoyiAvital commented Oct 4, 2023

Added a comment about r-stretch no applied on images with a specified height.

Reflecting comments by @cderv on quarto-dev/quarto-cli#7128.

Added a comment about `r-stretch` no applied on images with a specified `height`.
@cscheid
Copy link
Collaborator

cscheid commented Oct 4, 2023

Thanks for the contribution. I understand where you're coming from but I want to rephrase this a bit.

@RoyiAvital
Copy link
Contributor Author

@cscheid , No problem. English is not my native, so feel free to polish it.

@RoyiAvital
Copy link
Contributor Author

@cscheid , Should I remove this pull request or are you changing on top of it?

@cscheid
Copy link
Collaborator

cscheid commented Oct 14, 2023

You can leave it open; we just haven't decided what's the best way to document this.

@RoyiAvital
Copy link
Contributor Author

@cscheid , A gentle ping on this.

@cscheid
Copy link
Collaborator

cscheid commented Feb 2, 2024

@RoyiAvital Please don't. Our time is limited and pinging us like this makes it worse. The sentence you're trying to add will overall increase the confusion instead of decrease it; I appreciate your attempt but I'm just going to go ahead and close this.

@cscheid cscheid closed this Feb 2, 2024
@RoyiAvital RoyiAvital deleted the patch-1 branch February 2, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants