Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for SCSS variables in revealjs #1446

Open
wants to merge 3 commits into
base: prerelease
Choose a base branch
from

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Nov 6, 2024

This is a companion PR to Revealjs callout update to be merged in

It adds documentation for SCSS variable available to customize callouts.

@cwickham this PR also adds a new feature for our doc: Adding a color box next to some part mentioning a color.

Basically doing [`<hexcolor>`]{.color-box} would use the hexcolor to create the box. It would work with any text using [any content]{.color-box color="hexcolor"}

image

We could probably use that into the website in other places, and we could also make it a shortcode syntax if easier.

I noticed a few changes in preview locally regarding tables in documentation. I'll check if this is happening with the preview here too. I wonder if our brand change have had side effect

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🚀 Deployed on https://deploy-preview-1446.quarto.org

@github-actions github-actions bot temporarily deployed to pull request November 6, 2024 15:15 Inactive
@cderv
Copy link
Collaborator Author

cderv commented Nov 6, 2024

Update is here: https://deploy-preview-1446.quarto.org/docs/presentations/revealjs/themes.html#callouts

I noticed a few changes in preview locally regarding tables in documentation. I'll check if this is happening with the preview here too. I wonder if our brand change have had side effect

We don't see the darker border in table, so this is coming to latest dev version not yet built in a pre-release

@cderv cderv requested a review from cwickham November 6, 2024 15:19
@cderv
Copy link
Collaborator Author

cderv commented Nov 6, 2024

@cwickham just asking for review if you think this should be done different, or more explicit. And to have feedback on the filter idea.

Then this is to be merged after quarto-cli PR is merged

@cderv
Copy link
Collaborator Author

cderv commented Nov 6, 2024

Then this is to be merged after quarto-cli PR is merged

PR is merged. Waiting for confirmation here before merging

Copy link
Collaborator

@cwickham cwickham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love the colorbox idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants