Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarto fails for nbdev starting with 1.3.181 #4295

Closed
2 of 4 tasks
xl0 opened this issue Feb 9, 2023 · 4 comments · Fixed by #4301
Closed
2 of 4 tasks

Quarto fails for nbdev starting with 1.3.181 #4295

xl0 opened this issue Feb 9, 2023 · 4 comments · Fixed by #4301
Assignees
Labels
bug Something isn't working
Milestone

Comments

@xl0
Copy link

xl0 commented Feb 9, 2023

Bug description

I'm not exactly sure what is the culprit.
Steps to reproduce:

  • Clone fastai/nbdev
  • Install nbdev if you don't have it already.
    • pip install -e .[dev] in the nbdev directory.
  • run nbdev_docs. It will fail towards the end:
[ 1/42] index.qmd
[ 2/42] explanations/index.qmd
WARNING: File /ssd/xl0/work/code/nbdev/_proc/explanations/config.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/explanations/why_nbdev.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/explanations/directives.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/explanations/docs.ipynb in the listing 'listing' contains no metadata.
[ 3/42] explanations/config.ipynb
[ 4/42] explanations/why_nbdev.ipynb
[ 5/42] explanations/directives.ipynb
[ 6/42] explanations/docs.ipynb
[ 7/42] blog/index.qmd
[ 8/42] blog/posts/2022-07-28-nbdev2/index.qmd
[ 9/42] blog/posts/2022-11-07-spaces/index.qmd

Starting python3 kernel...Done

Executing 'index.ipynb'
  Cell 1/1...Done

[10/42] blog/posts/2022-08-25-jupyter-git/index.qmd
[11/42] getting_started.ipynb
[12/42] migrating.ipynb
[13/42] api/01_config.ipynb
[14/42] api/17_serve.ipynb
[15/42] api/index.qmd
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/01_config.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/17_serve.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/12_test.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/07_merge.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/18_release.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/02_maker.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/08_showdoc.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/09_frontmatter.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/03_process.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/05_doclinks.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/14_quarto.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/11_clean.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/16_migrate.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/15_qmd.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/06_sync.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/04_export.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/10_processors.ipynb in the listing 'listing' contains no metadata.
WARNING: File /ssd/xl0/work/code/nbdev/_proc/api/13_cli.ipynb in the listing 'listing' contains no metadata.
[16/42] api/12_test.ipynb
[17/42] api/07_merge.ipynb
[18/42] api/18_release.ipynb
[19/42] api/02_maker.ipynb
[20/42] api/08_showdoc.ipynb
[21/42] api/09_frontmatter.ipynb
[22/42] api/03_process.ipynb
[23/42] api/05_doclinks.ipynb
[24/42] api/14_quarto.ipynb
[25/42] api/11_clean.ipynb
[26/42] api/16_migrate.ipynb
[27/42] api/15_qmd.ipynb
[28/42] api/06_sync.ipynb
[29/42] api/04_export.ipynb
[30/42] api/10_processors.ipynb
[31/42] api/13_cli.ipynb
[32/42] tutorials/qmd_intro.qmd

Starting python3 kernel...Done

Executing 'qmd_intro.ipynb'
  Cell 1/1...Done

[33/42] tutorials/tutorial.ipynb
ERROR: Internal Error: Couldn't resolve width and height of SVG

I hope this rings a bell immediately and we don't have to dig deeper into the intimate nbdev-quarto interactions.

I'm seeing the same thing locally and also on GitHub CI, so don't think this is specific to any Linux version in particular.
Version 1.3.178 works fine.

Checklist

  • Please include a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.
  • Please format your issue so it is easier for us to read the bug report.
  • Please document the RStudio IDE version you're running (if applicable), by providing the value displayed in the "About RStudio" main menu dialog?
  • Please document the operating system you're running. If on Linux, please provide the specific distribution.
@xl0 xl0 added the bug Something isn't working label Feb 9, 2023
@cscheid cscheid self-assigned this Feb 9, 2023
@cscheid cscheid added this to the v1.3 milestone Feb 9, 2023
@cscheid
Copy link
Collaborator

cscheid commented Feb 9, 2023

Thanks for the tight bracketing on the good/bad versions. I'll take a look at this right away.

@cscheid
Copy link
Collaborator

cscheid commented Feb 9, 2023

This is caused by the upgrade of the deno_dom library from 0.20.0 to 0.35.0, specifically 5b3e0d7.

@cscheid
Copy link
Collaborator

cscheid commented Feb 9, 2023

This appears to be an upstream bug on deno_dom: b-fuze/deno-dom#133. We'll try to work around it for now.

cscheid added a commit that referenced this issue Feb 9, 2023
* workaround upstream getNamedItem issue. Closes #4295
* add regression test
@cscheid
Copy link
Collaborator

cscheid commented Feb 9, 2023

@xl0 Thanks for the report! We're now working around that deno_dom bug, and new quarto prerelease installers are being built. I hope you don't mind that I added the failing .ipynb to our regression suite so we keep track of this forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants