fix: \f form feed character ({{< pagebreak >}}) not valid in PowerPoint (pptx)
#11896
Conversation
mcanouil
changed the title
\f form feed character not valid in Powerpoint\f form feed character ({{< pagebreak >}} not valid in PowerPoint (pptx)
mcanouil
changed the title
\f form feed character ({{< pagebreak >}} not valid in PowerPoint (pptx)\f form feed character ({{< pagebreak >}}) not valid in PowerPoint (pptx)
|
Thanks ! Indeed pptx was not handled. Should we just ignore pagegreak by returning an empty list ? This would ignore the pagebreak effect in powerpoint I think.
Yes we have function for testing PPTX content : Look at examples in |
|
Sorry, but those functions do not seem to check the overall document integrity or are they? I mean like checking that the document does not raise an error popup when it is opened.
I thought about this approach but also thought that adding the exception with the specific solution for the formats makes it easier to maintain/check. |
There was a problem hiding this comment.
I mean like checking that the document does not raise an error popup when it is opened.
Oh sorry. I misunderstood. No they do not. I don't know if this can be check (i.e. testing it opens ok). We don't check this either for PDF output.
I think we have an issue about validating Open XML produced (same way as Pandoc does it for Word). But I don't know if it works the same for PPTX.
Edit: this one
There was a problem hiding this comment.
I would still add some test that checks maybe
- Number of slides is as expected
- Content where pagebreak happens does nothing
Something like
---
title: Test pagebreak in pptx
format: pptx
---
# Slide
Before
{{< pagebreak >}}
After
should be equivalent in content to
---
title: Test pagebreak in pptx
format: pptx
---
# Slide
Before
{{< pagebreak >}}
After
For Docx we have snapshot test, but not for pptx yet. But checking small part of output is probably better for the long run.
If you prefer, I can add the test.
There was a problem hiding this comment.
I would still add some test that checks maybe
- Number of slides is as expected
- Content where pagebreak happens does nothing
Something like
---
title: Test pagebreak in pptx
format: pptx
---
# Slide
Before
{{< pagebreak >}}
After
should be equivalent in content to
---
title: Test pagebreak in pptx
format: pptx
---
# Slide
Before
{{< pagebreak >}}
After
For Docx we have snapshot test, but not for pptx yet. But checking small part of output is probably better for the long run.
If you prefer, I can add the test.
|
I see what tests to add, but if you have the time, probably faster for you to add them. |
Ensure that the pagebreak shortcode does not disrupt PowerPoint rendering by returning an empty paragraph instead of causing issues with a form feed character.
Fixes #11893.
Is there a way to test OpenXML document integrity in Quarto?