Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossrefs: combined internal and external references don't work #1186

Open
mcanouil opened this issue Jun 20, 2022 · 5 comments
Open

Crossrefs: combined internal and external references don't work #1186

mcanouil opened this issue Jun 20, 2022 · 5 comments
Assignees
Labels
bug Something isn't working crossref
Milestone

Comments

@mcanouil
Copy link
Collaborator

mcanouil commented Jun 20, 2022

Bug description

Cross references are not parsed properly when combining figure reference and article reference, i.e., the article reference is missing

See: https://github.com/mcanouil/quarto-issues/tree/main/quarto-cli-1186

Possibly related to #1155

Quarto: 0.9.592 (I tried to upgrade to 598 and broke Quarto)
OS: MacOS arm64

@mcanouil mcanouil added the bug Something isn't working label Jun 20, 2022
@mcanouil mcanouil changed the title Cross references not parsed properly. Cross references not parsed properly Jun 20, 2022
@jjallaire jjallaire self-assigned this Jun 20, 2022
@jjallaire jjallaire added this to the 1.0 milestone Jun 20, 2022
@jjallaire
Copy link
Collaborator

Thanks for reporting this! I think the problem here is that Quarto resolve the cross-reference before Pandoc runs the citeproc filter, and the resolved crossref ends up making the citation syntax invalid. This will be a very tricky one to unwind so will have to wait until after our v1.0 release.

@mcanouil
Copy link
Collaborator Author

@cscheid I was going through my issues and checked this one.
Do you think it can be part of #4944

Below is from 1.3.361.
The first item in the list has the issue.

Quarto documentHTML
---
title: "Untitled"
format: 
  html:
    self-contained: true
bibliography: biblio.bib
---

- This is a ref to article and figure [@canouil_nacho_2019; @fig-plot].
- This is a ref to article and figure @canouil_nacho_2019, @fig-plot.

- This is a ref alone [@canouil_nacho_2019].
- This is a ref alone @canouil_nacho_2019.

```{r}
#| label: fig-plot
#| fig-cap: "Caption"
plot(1)
```
image

@cscheid
Copy link
Collaborator

cscheid commented Jun 17, 2023

I'll take a look at it. Can you add it to the epic? Thanks.

@mcanouil
Copy link
Collaborator Author

Not enough permission to edit the post. At best I can comment. 🤷‍♂️

@cscheid
Copy link
Collaborator

cscheid commented Jun 17, 2023

Oh, I apologize, I thought you had edit permissions!

@cderv cderv mentioned this issue Jun 19, 2023
62 tasks
@cscheid cscheid modified the milestones: Future, v1.5 Dec 1, 2023
@cscheid cscheid changed the title Cross references not parsed properly Crossrefs: combined internal and external references don't work Mar 12, 2024
@cscheid cscheid modified the milestones: v1.5, Future Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crossref
Projects
None yet
Development

No branches or pull requests

3 participants