-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Vercel deployments to Github Actions #2227
Comments
After experimenting with different approaches on #2229, I still think this is a good idea, but there are two problems that don't allow us to implement a perfect solution. First, we need to detect whether a deployment should happen. On Vercel, Using If we disable Second, there are several different ways how to organize the pipeline, and each one has its own tradeoffs. In our current setup, we run I thought that I'd be able to run build -> deploy in a clear correct order if we move to Github Actions. But:
What if we did everything in a single Actions job by running But there are downsides with this approach too:
So there's a conceptual mismatch between Github Actions "static dependency graph" approach, and turborepo's "dynamic dependency graph based on package.json dependencies and turbo.json configs". This problem is less important than the one with For now, I'm going to put this on hold, maybe for a week or two, and check later if I still want to do this or if I have any better ideas. |
Other findings for when I get back to it:
|
https://vercel.com/guides/how-can-i-use-github-actions-with-vercel
Benefits:
turbo build
-> deploy orderprisma migrate
with Github Actions (we could run migration before deploying; that's not possible with Vercel which deploys immediately on commit)The text was updated successfully, but these errors were encountered: