Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not get the item of "Tomcat version" #51

Open
tonny1983 opened this issue Jul 21, 2019 · 0 comments
Open

Can not get the item of "Tomcat version" #51

tonny1983 opened this issue Jul 21, 2019 · 0 comments

Comments

@tonny1983
Copy link

tonny1983 commented Jul 21, 2019

First, thanks a lot for your excellent project.

However, there's one thing in trouble to get the item of Tomcat version. Actually, the result for Catalina:type=Server->serverInfo is something like <datetime> org.archive.jmx.Client serverInfo: Apache Tomcat/9.0.13. and unfortunately, there's a space between Apache and Tomcat/9.0.13. Therefore, in this case, the if-statement of line 192 in your tomcat.py will be false, and there's no any output then.

I don't know why you use "\n" to split the JMX result from cmdline-jmxclient (in line 166 of the same python script), and it seems ": "(colon and a space) can be used in the case. And then, a list with two items will be returned, the last one of which should be the expected value. The same issue also exists in jvm.py which cases not to get the jvm Name.

BTW, from tomcat ver. 8, there's a new connector called AjpNio2Protocol(using org.apache.coyote.http11.Http11Nio2Protocol) and its name in MBean is "http-nio2-<port>", and I recommend to handle this connector.

@tonny1983 tonny1983 changed the title Can not get the tem of "Tomcat version" Can not get the item of "Tomcat version" Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant