Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Unit test for ensuring finalization works after reorg #2164

Closed
kamilsa opened this issue Aug 1, 2024 · 0 comments · Fixed by #2167
Closed

[Enhancement]: Unit test for ensuring finalization works after reorg #2164

kamilsa opened this issue Aug 1, 2024 · 0 comments · Fixed by #2167
Assignees
Labels

Comments

@kamilsa
Copy link
Contributor

kamilsa commented Aug 1, 2024

Description

Polkadot-SDK version 1.15 contains a fix of potential finality stall after reorg:
paritytech/polkadot-sdk#5153

It was the case that in Polkadot SDK best_chain_containing on previously prevoted block could return None if reorg happened. Task is to write the same unit test in KAGOME and ensure that this bug is not the case in our implementation

https://github.com/paritytech/polkadot-sdk/pull/5153/files#diff-2abb97f1751549dcc1eb9422bcfc27837e30af682fe3aa32f9bed833883be334R1827

Motivation

Ensures that finality cannot stall after reorg

Additional context

No response

Are you planning to do it yourself in a pull request ?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants