Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struct cm_mnbc_sound_indicate is wrong #163

Open
vinicius-smartme opened this issue Jun 30, 2022 · 1 comment
Open

struct cm_mnbc_sound_indicate is wrong #163

vinicius-smartme opened this issue Jun 30, 2022 · 1 comment

Comments

@vinicius-smartme
Copy link

The struct cm_mnbc_sound_indicate is wrong.

It should be:

typedef struct __packed cm_mnbc_sound_indicate
{
	struct ethernet_hdr ethernet;
	struct homeplug_fmi homeplug;
	uint8_t APPLICATION_TYPE;
	uint8_t SECURITY_TYPE;
	struct __packed
	{
		uint8_t SenderID [SLAC_UNIQUE_ID_LEN];
		uint8_t CNT;
		uint8_t RunID [SLAC_RUNID_LEN];
		uint8_t RSVD [8];
		uint8_t RND [SLAC_RND_LEN];
	}
	MSVarField;
}

However, it is:

typedef struct __packed cm_mnbc_sound_indicate
{
	struct ethernet_hdr ethernet;
	struct homeplug_fmi homeplug;
	uint8_t APPLICATION_TYPE;
	uint8_t SECURITY_TYPE;
	struct __packed
	{
		uint8_t SenderID [SLAC_UNIQUE_ID_LEN];
		uint8_t CNT;
		uint8_t RunID [SLAC_RUNID_LEN];
		uint8_t RND [SLAC_UNIQUE_ID_LEN];
	}
	MSVarField;
}
@MichaelBMiner
Copy link

Has this been fixed in master? I can confirm this causes malformed packets in sounding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants