Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about CM_SET_KEY.CNF result field #161

Open
catphish opened this issue May 18, 2022 · 3 comments
Open

Confused about CM_SET_KEY.CNF result field #161

catphish opened this issue May 18, 2022 · 3 comments

Comments

@catphish
Copy link

catphish commented May 18, 2022

According to the published Homeplug specifications, in the result field of CM_SET_KEY.CNF, a value of 0 is success and 1 is failure. This is further reflected in Wireshark's decoder. However. my device returns a 1 in this field, and apparently sets the key correctly. Furthermore, the code in this repository treats non-zero as a success.

https://github.com/qca/open-plc-utils/blob/358dfcf78bdaf7b0b13dcdf91cb1aae1789f2770/slac/evse_cm_set_key.c#L170..L173

Am I misunderstanding something?

@oliviermaridat
Copy link

I confirm there is a difference between the Homeplug specification and reality.
I do not know why but I would be glad to!

@vbudko
Copy link

vbudko commented May 18, 2022

I confirm there is a difference between the Homeplug specification and reality. I do not know why but I would be glad to!

Hi Olivier,
The Result field interpretation used by Qualcommis based on HomePlug AV 1.0 specification, where 0x01 is a success and 0x01 is a failure.
The later versions of the HomePlug specification (HomePlug AV 1.1 and HomePlug Green PHY) use a different interpretation (it considers the result field as being set to 0x00 for success and 0x01 for failure).
Hope that helps.
BR, Vasily Budko

@oliviermaridat
Copy link

Thanks for your feedback Vasily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants