Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot toggle to lightmode on WebUI #21600

Closed
erentar opened this issue Oct 13, 2024 · 13 comments · Fixed by #21613
Closed

Cannot toggle to lightmode on WebUI #21600

erentar opened this issue Oct 13, 2024 · 13 comments · Fixed by #21613
Labels
WebUI WebUI-related issues/changes

Comments

@erentar
Copy link

erentar commented Oct 13, 2024

qBittorrent & operating system versions

5.0.0-r2-ls358

What is the problem?

It is impossible to toggle between dark and light modes without editing the css.

Steps to reproduce

No response

Additional context

The UI should allow a toggle button if the user would prefer not to see the webpage in dark mode

Log(s) & preferences file(s)

irrelevant

@thalieht thalieht added the WebUI WebUI-related issues/changes label Oct 13, 2024
@Auximen
Copy link

Auximen commented Oct 13, 2024

This is terrible, I can't return the light theme to Docker on Synology NAS. I don't want to change Windows settings to light just so that in one application - qBittorrent web interface is light. Now I'm busy looking for alternative torrent clients. Why was it necessary to release this 5.0.0 update, which spoils the web interface so much?

@xavier2k6
Copy link
Member

clear browser cache

@HanabishiRecca
Copy link
Contributor

I don't want to change Windows settings to light just so that in one application - qBittorrent web interface is light.

You could also tweak that on a browser level. E.g. how to do it in Firefox.

Why was it necessary to release this 5.0.0 update, which spoils the web interface so much?

It's your opinion. I like the new style and like to have the dark mode everywhere.
And I won't even ask why you have the entire system in the dark mode and want only 1 specific app to flashbang you in the light mode.

@erentar
Copy link
Author

erentar commented Oct 13, 2024

You do not know if this is an accessibility issue, if the user needs dark theme on other webpages but not on this one

If a user needs a functionality, (and might i say a rather simple one) that will make their usage easier and more accessible, why not?

@erentar
Copy link
Author

erentar commented Oct 13, 2024

I personally prefer my browser in dark mode due to the tabs however i prefer some webpages to be in light mode. Fortunately, most webpages (and also other selfhosted services) have recognised that this might create issues for their users, and thus offer explicit toggle buttons to switch between the two if the user so wishes.

I believe this is also why I was unable to hack firefox into making just this webpage into light mode and leave the rest dark, because most webpages handle this on their own

@HanabishiRecca
Copy link
Contributor

I'm not against it. I just dislike the pointless rant above.

Although, considering that we use CSS prefers-color-scheme feature, implementing a toggle would be tricky.

@kebien6020
Copy link

kebien6020 commented Oct 14, 2024

I have a similar ask here, but only because currently dark mode is kind of unreadable

Click to show screenshots

image
image
image

Edit: Collapsed the screenshots to avoid cluttering the thread. Btw, yes, clearing the cache worked.

@HanabishiRecca
Copy link
Contributor

I have a similar ask here, but only because currently dark mode is kind of unreadable

Clear the browser cache.

Are you guys seriously think this could be the intentional design? Not a tiniest suspicion about something being wrong here?

@Auximen
Copy link

Auximen commented Oct 14, 2024

I have a similar ask here, but only because currently dark mode is kind of unreadable

Clear the browser cache.

Are you guys seriously think this could be the intentional design? Not a tiniest suspicion about something being wrong here?

In all the applications and interfaces I know, I can choose between a dark or light interface in the application settings. Why does the developer tie the interface to Windows or browser settings and remove the ability to choose the style manually? This is madness! I have a dark browser, but I find it convenient to use many applications in light.

@HanabishiRecca
Copy link
Contributor

Why does the developer tie the interface to Windows or browser settings

Because web standards have an option for that.

and remove the ability to choose the style manually?

Except you're lying. WebUI never had such option. Nothing has been taken from you.

I have a dark browser, but I find it convenient to use many applications in light.

Sure. But qBittorrent is a free and open source software. So making demands here is pointless.
The guy implemented the dark theme have done it the best way he could - #19901. It was a long and tedious process.
You know how to do better? Contributions are welcome.

Yes, explicit toggle is a useful feature. Again, I'm not against it.
But it could be implemented only when someone would go and implement it. Ranting about it would not change anything.

@sledgehammer999
Copy link
Member

Until this is solved via UI you can temporarily make your browser use a different color scheme for the particular tab with the WebUI open.
I only have instructions for Firefox but I think something similar should be possible in Chrome.
Ctrl+Shift+I to open Developer tools. Then click one of these icons:
Untitled

@HanabishiRecca
Copy link
Contributor

you can temporarily make your browser use a different color scheme for the particular tab with the WebUI open.

It requires to keep the devtools open though.

@sledgehammer999
Copy link
Member

It requires to keep the devtools open though.

Damn.

sledgehammer999 added a commit that referenced this issue Oct 14, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 14, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 14, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 20, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 20, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 20, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 21, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 21, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Oct 21, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Nov 1, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Nov 1, 2024
sledgehammer999 added a commit to sledgehammer999/qBittorrent that referenced this issue Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants