Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video.json schema should not allow additional properties #1173

Open
jonafato opened this issue Jul 28, 2024 · 0 comments · May be fixed by #1174
Open

video.json schema should not allow additional properties #1173

jonafato opened this issue Jul 28, 2024 · 0 comments · May be fixed by #1174

Comments

@jonafato
Copy link
Member

The video schema currently allows additional properties on video data, but these attributes are not used by the website (and cannot be used without first being validated by the schema). The schema should disallow this, which will require first removing unneeded data from video files or moving data into a more correct field (e.g. see https://github.com/pyvideo/data/tree/main/writethedocs-au-2018 for an example of data that is present in an "abstract" field but should be in the "description" field instead).
jonafato added a commit that referenced this issue Jul 28, 2024
@jonafato
Disallow additional properties on video schema
85eec51 
The intent of this change is to update the schema without any test
failures. This means that other changes that affect the data should
happen independently from the pull request associated with this commit,
and it should be kept up to date and merged once the schema tests pass.
To contribute to this change, open PRs that would correct any data that
does not conform to the JSON schema. Discussion regarding other schema
updates should happen in the associated issue at #1173.

Resolves #1173.
This was referenced Jul 28, 2024
Draft
Merged
jonafato added a commit that referenced this issue Aug 3, 2024
@jonafato
Disallow additional properties on video schema
a85f32c 
The intent of this change is to update the schema without any test
failures. This means that other changes that affect the data should
happen independently from the pull request associated with this commit,
and it should be kept up to date and merged once the schema tests pass.
To contribute to this change, open PRs that would correct any data that
does not conform to the JSON schema. Discussion regarding other schema
updates should happen in the associated issue at #1173.

Resolves #1173.
@jonafato jonafato mentioned this issue Aug 9, 2024
Merged
jonafato added a commit that referenced this issue Aug 13, 2024
@jonafato
Disallow additional properties on video schema
58847ff 
The intent of this change is to update the schema without any test
failures. This means that other changes that affect the data should
happen independently from the pull request associated with this commit,
and it should be kept up to date and merged once the schema tests pass.
To contribute to this change, open PRs that would correct any data that
does not conform to the JSON schema. Discussion regarding other schema
updates should happen in the associated issue at #1173.

Resolves #1173.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow additional properties on video schema pyvideo/data
1 participant
@jonafato