From 8b77b67aeebf7906acf37ae1bf35dd95e74b2383 Mon Sep 17 00:00:00 2001 From: Joe Cummings Date: Mon, 27 Feb 2023 16:04:21 -0500 Subject: [PATCH 1/2] Double quote to prevent globbing and word splitting --- .github/scripts/validate_binaries.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index 43c4a36acb..62563888f5 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -2,12 +2,12 @@ if [[ ${MATRIX_PACKAGE_TYPE} = "conda" ]]; then #special case for Python 3.11 if [[ ${MATRIX_PYTHON_VERSION} == '3.11' ]]; then - conda install -y torchtext -c malfet -c ${PYTORCH_CONDA_CHANNEL} + conda install -y torchtext -c malfet -c "${PYTORCH_CONDA_CHANNEL}" else - conda install -y torchtext -c ${PYTORCH_CONDA_CHANNEL} + conda install -y torchtext -c "${PYTORCH_CONDA_CHANNEL}" fi else - pip install ${PYTORCH_PIP_PREFIX} torchtext --index-url ${PYTORCH_PIP_DOWNLOAD_URL} + pip install "${PYTORCH_PIP_PREFIX}" torchtext --index-url "${PYTORCH_PIP_DOWNLOAD_URL}" fi python ./test/smoke_tests/smoke_tests.py From 3bd4b126665184f655c043f47a43ae1d1b1b465c Mon Sep 17 00:00:00 2001 From: Joe Cummings Date: Wed, 1 Mar 2023 11:17:01 -0500 Subject: [PATCH 2/2] Update validate_binaries.sh --- .github/scripts/validate_binaries.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/validate_binaries.sh b/.github/scripts/validate_binaries.sh index 62563888f5..a4c9bea2ca 100755 --- a/.github/scripts/validate_binaries.sh +++ b/.github/scripts/validate_binaries.sh @@ -7,7 +7,7 @@ if [[ ${MATRIX_PACKAGE_TYPE} = "conda" ]]; then conda install -y torchtext -c "${PYTORCH_CONDA_CHANNEL}" fi else - pip install "${PYTORCH_PIP_PREFIX}" torchtext --index-url "${PYTORCH_PIP_DOWNLOAD_URL}" + pip install ${PYTORCH_PIP_PREFIX} torchtext --index-url "${PYTORCH_PIP_DOWNLOAD_URL}" fi python ./test/smoke_tests/smoke_tests.py