Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Card-Game Environment #2272

Closed
mjlaali opened this issue Jul 7, 2024 · 2 comments · Fixed by #2345
Closed

[Feature Request] Support Card-Game Environment #2272

mjlaali opened this issue Jul 7, 2024 · 2 comments · Fixed by #2345
Assignees
Labels
enhancement New feature or request

Comments

@mjlaali
Copy link

mjlaali commented Jul 7, 2024

Motivation

Card games are useful to study RL algorithms in control settings, with simple interface and simple to grasp.

Solution

Create a wrapper on top of RLCard games for TorchRL. This is 100% python library.

Alternatives

Create a wrapper on top of open_spiel games for TorchRL
While this is also a promising library and has implementation in C++ for games.
I am not clear on difficulty of adding this library.

Additional context

I don't have a strong data point on these libraries and which one is the best option for TorchRL

Checklist

  • [ x ] I have checked that there is no similar issue in the repo (required)
@mjlaali mjlaali added the enhancement New feature or request label Jul 7, 2024
@vmoens
Copy link
Contributor

vmoens commented Jul 9, 2024

Related: #2133

I'd be keen on integrate both of these. The only thing I need to get started is an example of a rollout with these libs.

@mjlaali
Copy link
Author

mjlaali commented Jul 15, 2024

Does this help?

https://github.com/google-deepmind/open_spiel/blob/master/open_spiel/python/examples/tic_tac_toe_qlearner.py

It shows how to roll out and train an agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants