Only use outside border of stroke in text() #8701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
stroke_outside
branch
2 times, most recently
from
eb0f060 to
bc4788e
Compare
radarhere
force-pushed
the
stroke_outside
branch
from
bc4788e to
0318304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8697
The issue finds that when Pillow draws normal text onto stroked text, there might be an unexpected gap between the the outside of the normal text and the inside border of the stroked text.
When drawing stroked text, FreeType returns a glyph with an outside border and an inside border. We can ask FreeType to leave out the inside border though, creating a filled glyph. With that change, the output is corrected.
See https://freetype.org/freetype2/docs/reference/ft2-glyph_stroker.html#ft_glyph_stroke and https://freetype.org/freetype2/docs/reference/ft2-glyph_stroker.html#ft_glyph_strokeborder for documentation.