New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream bindings are slow and broken #240

Open

jonathanunderwood opened this issue Feb 17, 2022 · 0 comments

Labels

help wanted stream

Member

jonathanunderwood commented Feb 17, 2022 •

edited

Loading

The streaming bindings are currently flagged as experimental and are not built by default. The problems with these bindings include:

The test suite fails on windows (64 bit) and Aarch64 architectures
The test suite takes too long to run hindering development
Decompression performance is terrible (slow stream decompression #218)
Ring buffer is not implemented (Streams module does not support ring buffer #187)

Overall the design of these bindings and their test suite needs revisiting. An approach to consider:

Provide bindings in the extension module for the API bindings, but not the double buffer and ring buffer implementations
Implement double buffer and ring buffer functionality at the Python layer
Drastically reduce the set of test cases

jonathanunderwood added help wanted stream labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment