Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _pytest.compat.is_generator() and just use inspect.isgeneratorfunction() directly #12960

Open
Zac-HD opened this issue Nov 13, 2024 · 0 comments
Labels
good first issue easy issue that is friendly to new contributor type: refactoring internal improvements to the code

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Nov 13, 2024

It's already equivalent in practice, and deleting the few uses and handful of tests will make it easier for contributors to understand code which uses the stdlib function instead.

While we're there, I'd like to turn the xfail on "yield tests" - a noop since Pytest 4! - into a hard error, to reduce the risk that users incorrectly believe that they're testing something.

@Zac-HD Zac-HD added the type: refactoring internal improvements to the code label Nov 13, 2024
@webknjaz webknjaz added the good first issue easy issue that is friendly to new contributor label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue easy issue that is friendly to new contributor type: refactoring internal improvements to the code
Projects
None yet
Development

No branches or pull requests

2 participants