Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when module name contains hyphens #1003

Closed
LLyaudet opened this issue Oct 19, 2023 · 2 comments
Closed

Warning when module name contains hyphens #1003

LLyaudet opened this issue Oct 19, 2023 · 2 comments

Comments

@LLyaudet
Copy link

Hello,
Would you be interested in adding a warning when the module under src directory contains hyphens/is not a valid python identifier?
pypa/packaging.python.org#1316
Best regards,
Laurent Lyaudet

@ofek
Copy link
Collaborator

ofek commented Nov 30, 2023

Closing since we have pypa/packaging.python.org#1424

@ofek ofek closed this as completed Nov 30, 2023
@LLyaudet
Copy link
Author

Hello @ofek :)

Are you sure that it would not be better to have a warning in Hatch program on top of the warning in the tutorial ?

The goal of this issue was not exactly the same as the goal of issue pypa/packaging.python.org#1316

Moreover even the warning in the tutorial is subject to barrage fire right now.
I still think a simple warning like "Hatch found the module blabla that is not a valid Python identifier." would be a nice addition.

Best regards,
Laurent Lyaudet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants