Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type hints + mypy #66

Open
1 task
drbenvincent opened this issue Nov 16, 2022 · 3 comments
Open
1 task

type hints + mypy #66

drbenvincent opened this issue Nov 16, 2022 · 3 comments

Comments

@drbenvincent
Copy link
Collaborator

drbenvincent commented Nov 16, 2022

Add type hints and run mypy.

drbenvincent added a commit that referenced this issue Dec 4, 2022
Add tests Model Builder. Starts #66 on mypy, and #25 on tests
@drbenvincent drbenvincent added this to the Pay off technical debt milestone Dec 5, 2022
@Padarn
Copy link

Padarn commented Apr 9, 2023

Hyy @drbenvincent I'd be happy to lend a hand here if you like. I assume this issue is meant to cover adding mypy testing?

Fix numpy type hint here

Presumably to use nptyping?

@drbenvincent
Copy link
Collaborator Author

Hi @Padarn. Sure, I've not used mypy so I was going to learn that and improve the type hinting. But if you wanted to submit a PR, that would be great. It probably makes sense to add some short usage instructions in CONTRIBUTING.md as well.

My comment about numpy typing is a little cryptic, but I think I must have meant to add shape information (if required). But perhaps that's optional.

@Padarn
Copy link

Padarn commented Apr 11, 2023

Haha got it. Sure let me take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants