Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid vectorizing num_chain=1 #318

Closed
wants to merge 1 commit into from
Closed

Avoid vectorizing num_chain=1 #318

wants to merge 1 commit into from

Conversation

junpenglao
Copy link
Member

Close #317

@kyleabeauchamp
Copy link
Contributor

LGTM, do we want to copy in the MRE from #317 as a test?

@kyleabeauchamp
Copy link
Contributor

I'm not super aware of possible side effects of this change though, so someone else probably needs approve.

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          36       36           
  Lines        2822     2822           
=======================================
  Hits         2565     2565           
  Misses        257      257           
Impacted Files Coverage Δ
pymc4/mcmc/samplers.py 93.57% <100.00%> (ø)

@junpenglao
Copy link
Member Author

Filed an issue on TFP tensorflow/probability#1071

@fonnesbeck fonnesbeck closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sampling fails when num_chains=1
3 participants