Foward compile_kwargs
to ADVI when init = "advi+..."
#7640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title. Now that we are allowed to pass
compile_kwargs
to pm.sample, it would be nice if these kwargs were also passed to any subroutines that are called before/after sampling. An obvious example is the call topm.fit
when the user setsinit = "advi+something"
. This PR forwards thecompile_kwargs
to ADVI.It also renames
fn_kwargs
tocompile_kwargs
in the variational sub-module. This harmonizes the naming convention across the library. A depreciation warning is added whenfn_kwargs
is used for backwards compatibility.Related Issue
compile_kwargs
in ADVI wheninit = 'advi+...'
#7638Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7640.org.readthedocs.build/en/7640/