-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laplace approximation #341
Comments
I am new to PYMC and probabilistic programming. While reading Statistical Rethinking I was looking for a Quadratic Approximation method for Python. I did not find any. Partly based on the first bullet point above I have created this package https://github.com/carsten-j/quad5. I have based in on the PYMC class ArrayStep such that I can use the sample method on PYMC model and automatically get constant, deterministic, and observed data in the inferencedata output from the sample method. Feedback is appreciated. |
Hi Carsten, Sorry I was slow on this – I was on holiday. This is really cool. Reading through the README, yes the I was unfamiliar with If you're willing, we would love you to contribute this to pymc-experimental. In this way, we can more formally review the code with the setup here (@elizavetasemenova, @zaxtax and I can review). There are step-by-step instructions on contributing to pymc here, but if there's anything you're struggling with I'm happy to help. Really excited to get this in. |
Hi. Thanks for the positive feedback. I am a bit busy for the next couple of days but after Wednesday I will start looking into how to contribute to PYMC experimental. |
Excellent, looking forward to it |
@carsten-j if we want to use Laplace as a step, it should probably fit in every iteration, specially if the step sampler is assigned only a subset of the model variables, since it should be conditioned on the rest of the variables. Also with stuff like As mentioned by @theorashid it probably makes more sense to have a Obtaining the the rest of the InferenceData metadata shouldn't be too hard, if you dig through the codebase you'll see that that happens after sampling anyway with |
I am using a Mac and Visual Studio Code. I can run tests from the commandline and I can also run tests from within Visual Studio Code. But when I add a breakpoint to a test and try to debug the test from Visual Studio Code then I get this error message
Do you know if debugging tests from Visual Studio Code should work? |
Not sure on your specific case, but I use VSCode's interface to run specific tests. I know VSCode has a test debug interface too which I haven't used but the comments here might help https://stackoverflow.com/questions/63619498/vs-code-python-debugging-pytest-test-with-the-debugger |
Part of INLA roadmap #340.
This would be a Laplace approximation for the entire posterior. Perhaps the API can be like the current PyMC VI API.
Notes
The text was updated successfully, but these errors were encountered: