Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MAD-X binaries from 5.06.00 to 5.07.00 #353

Closed
wants to merge 2 commits into from
Closed

Update MAD-X binaries from 5.06.00 to 5.07.00 #353

wants to merge 2 commits into from

Conversation

fsoubelet
Copy link
Member

Closes #352

Let's take this opportunity to see if the tests run properly with the new version, though there should be no hiccups.

@fsoubelet fsoubelet self-assigned this Nov 17, 2021
mihofer
mihofer approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@mihofer mihofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term, a switch to cpymad might be better, make things easier

@fsoubelet
Copy link
Member Author

While I fully agree @mihofer, that will be a massive amount of work and we clearly don't have time for it :(

@mihofer
Copy link
Contributor

mihofer commented Nov 17, 2021

While I fully agree @mihofer, that will be a massive amount of work and we clearly don't have time for it :(

I quickly checked and massive might be an overstatement, if I didn't miss anything, one may "only" need to redo the _run function in the madx_wrapper

omc3/omc3/madx_wrapper.py

Line 110 in a78e22c

def _run(full_madx_script, log_file=None, output_file=None, madx_path=MADX_PATH, cwd=None):

@fsoubelet
Copy link
Member Author

While I fully agree @mihofer, that will be a massive amount of work and we clearly don't have time for it :(

I quickly checked and massive might be an overstatement, if I didn't miss anything, one may "only" need to redo the _run function in the madx_wrapper

omc3/omc3/madx_wrapper.py

Line 110 in a78e22c

def _run(full_madx_script, log_file=None, output_file=None, madx_path=MADX_PATH, cwd=None):

That'd be the simple and ugly way to do it, the right way would be to make use of cpymad's power by properly using it.

@mihofer
Copy link
Contributor

mihofer commented Feb 23, 2022

In the meantime, 5.08 is the latest MAD-X version.

@fsoubelet fsoubelet closed this Jul 26, 2022
@fsoubelet fsoubelet deleted the update_binaries branch July 26, 2022 12:50
@pylhctokens pylhctokens added the Type: Feature A (suggetion for a) new feature or enhancement in functionality. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihofer mihofer mihofer approved these changes

@Mael-Le-Garrec Mael-Le-Garrec Awaiting requested review from Mael-Le-Garrec

@awegsche awegsche Awaiting requested review from awegsche

Assignees

@fsoubelet fsoubelet

Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update MAD-X Binaries
3 participants
@fsoubelet @mihofer @pylhctokens