No Access to ORT Environment (v2)

[aykut-bozkurt]

Hello, with the version v2, I see we plan to quit accessing to Environment. Actually, this makes sense since we allow 1 Environment per process. But it has a limitation for the following case:

We have a http service where we need to update the Environment if any setting, e.g. intra-op-parallelism and spin-control, changes. With the new version, this functionality goes away since we cannot recreate an Environment with new configuration. When we had access to it, we could drop it and recreate a new one in a controlled way (making sure there is no active run etc...).

One alternative might be to expose a function like environment_set_config. I may also think about it more. What do you think @decahedron1?

[decahedron1]

Would ea7d059 work? It allows ort::init to set the global environment after the first initialization. (Sessions will still need to be recreated to use the new environment, of course.)

[aykut-bozkurt]

So much thanks. This works almost as expected. Looks like 1 thing is missing. We need to invoke Drop of the Environment before calling CreateEnv(). Otherwise, ONNX Runtime will return the same environment instance.

After debugging, I found out that adding something like below just before calling CreateEnv works

pub fn commit(self) -> Result<()> {
  unsafe {
    *G_ENV.cell.get() = None; // this will invoke Drop for previous Environment
  };
  
  let env_ptr = if let Some(global_thread_pool) = self.global_thread_pool_options {
  .....

[decahedron1]

Fixed in 127154b

[aykut-bozkurt]

It works! Thank you.