From 683139e5e2c978b764ee058eb1141081add8fa2a Mon Sep 17 00:00:00 2001 From: Starbuck5 <46412508+Starbuck5@users.noreply.github.com> Date: Sat, 4 Jan 2025 22:34:23 -0800 Subject: [PATCH] Remove unnecessary lock in gfxdraw All the surrounding code is written to assume the surface has already been locked (which it has). Possibly this was a copy paste error many years ago, it's been in pygame/pygame-ce for at least 9 years. --- src_c/SDL_gfx/SDL_gfxPrimitives.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src_c/SDL_gfx/SDL_gfxPrimitives.c b/src_c/SDL_gfx/SDL_gfxPrimitives.c index 84cf120187..04ebb81bb9 100644 --- a/src_c/SDL_gfx/SDL_gfxPrimitives.c +++ b/src_c/SDL_gfx/SDL_gfxPrimitives.c @@ -4093,7 +4093,7 @@ ellipseColor(SDL_Surface *dst, Sint16 x, Sint16 y, Sint16 rx, Sint16 ry, result |= pixelColorNolock(dst, xmi, ypj, color); result |= pixelColorNolock(dst, xpi, ypj, color); result |= pixelColorNolock(dst, xmi, ymj, color); - result |= pixelColor(dst, xpi, ymj, color); + result |= pixelColorNolock(dst, xpi, ymj, color); } else { result |= pixelColorNolock(dst, xmi, y, color);