Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support for LZ4? #163

Open
gcflymoto opened this issue Sep 12, 2024 · 1 comment
Open

FR: Support for LZ4? #163

gcflymoto opened this issue Sep 12, 2024 · 1 comment

Comments

@gcflymoto
Copy link

First of all thank you for such an excellent library which provides our engineering community with simple, transparent, performant, and pythonic library to handle all kinds of compressed and uncompressed files. It reduces the complexity by 10x of handling all these formats.

We've recently been deploying LZ4, especially since the latest release 1.10.0 supports multi-threaded compression and decompression

Unfortunately https://github.com/python-lz4/python-lz4 development seems to have ceased.

Is there any possibility for adding python-zstandard style library? or support for invoking "lz4" CLI for now?

@marcelm
Copy link
Collaborator

marcelm commented Sep 13, 2024

Thanks for the kind words!

My first thought is that adding LZ4 sounds reasonable. Are you interested in submitting a PR? A couple of thoughts in random order:

  • Spawning lz4 as a process would be easiest for now.
  • Using python-lz4 as a library should also be needed, but the question is whether it should be a required or optional dependency. I don’t like that the lz4 wheel has 1.3 MB. This seems to be due to debugging info being included and could be reduced to around 100 kB. The Conda packages for lz4 itself plus the Python bindings (lz4-c and lz4) total <200 kB.
  • python-lz4 apparently not being maintained is a bummer.
  • Maybe the tests need some refactoring to avoid running too many of them?

@rhpvorderman What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants